refactor(joy_controller)!: prefix package and namespace with autoware #7382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
takayuki5168
added
the
tag:run-build-and-test-differential
Signed-off-by: Takayuki Murooka <[email protected]>
takayuki5168
force-pushed
the
feat/autoware-prefix-joy-controller
branch
from
1a9b094 to
f302e4c
Compare
Signed-off-by: Takayuki Murooka <[email protected]>
github-actions
bot
added
the
type:ci
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
takayuki5168
force-pushed
the
feat/autoware-prefix-joy-controller
branch
from
be4c676 to
5812743
Compare
takayuki5168
requested review from
rej55,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe and
tkimura4
as code owners
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…#7382) * add prefix Signed-off-by: Takayuki Murooka <[email protected]> * fix codeowner Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the autoware_ prefix to the package and puts headers in the autoware namespace.
Part of:
autowarefoundation/autoware#4569
Tests performed
psim
ros2 launch autoware_joy_controller joy_controller.launch.xmlcan be launched successfully though there is no real controllerEffects on system behavior
Nothing
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.